From 5bdb586a2cd79c18c932d7dfde09f638c296a358 Mon Sep 17 00:00:00 2001
From: Peter Stockings <pstockings@jadeworld.com>
Date: Sun, 10 Nov 2024 18:31:44 +1100
Subject: [PATCH] For endpoints page, remove faulty logic that attempted to
 persisted column view preferences and move Method column to 2nd pos

---
 templates/partials/endpoints_table.html | 66 +++++++++----------------
 1 file changed, 22 insertions(+), 44 deletions(-)

diff --git a/templates/partials/endpoints_table.html b/templates/partials/endpoints_table.html
index d182495..e89cc26 100644
--- a/templates/partials/endpoints_table.html
+++ b/templates/partials/endpoints_table.html
@@ -1,81 +1,59 @@
 <div class="overflow-x-auto">
     <!-- Column Toggle Checkboxes -->
-    <div class="mb-4 flex flex-col sm:flex-row flex-wrap items-start sm:items-center space-y-2 sm:space-y-0 sm:space-x-6"
-        _="
-         on load
-             let cols = [
-                 { class: 'col-endpoint', checkbox: 'toggle-endpoint' },
-                 { class: 'col-url', checkbox: 'toggle-url' },
-                 { class: 'col-methods', checkbox: 'toggle-methods' },
-                 { class: 'col-view_func', checkbox: 'toggle-view_func' },
-                 { class: 'col-description', checkbox: 'toggle-description' }
-             ]
-             for each col in cols
-                 let state = localStorage[col.class]
-                 if state is 'hidden'
-                     add .hidden to .{col.class}
-                     set checkbox {col.checkbox} to false
-                 else
-                     remove .hidden from .{col.class}
-                     set checkbox {col.checkbox} to true
-     ">
+    <div
+        class="mb-4 flex flex-col sm:flex-row flex-wrap items-start sm:items-center space-y-2 sm:space-y-0 sm:space-x-6">
         <label class="inline-flex items-center space-x-2" for="toggle-endpoint">
-            <input id="toggle-endpoint" type="checkbox" checked class="form-checkbox h-6 w-6 text-blue-600" _="
+            <input id="toggle-endpoint" type="checkbox" checked class="form-checkbox h-6 w-6 text-blue-600"
+                data-column="col-endpoint" _="
                    on change 
                        if me.checked then
                            remove .hidden from .col-endpoint
-                           set localStorage['col-endpoint'] to 'visible'
                        else
                            add .hidden to .col-endpoint
-                           set localStorage['col-endpoint'] to 'hidden'
                ">
             <span class="text-gray-700">Endpoint</span>
         </label>
-        <label class="inline-flex items-center space-x-2" for="toggle-url">
-            <input id="toggle-url" type="checkbox" checked class="form-checkbox h-6 w-6 text-blue-600" _="
-                   on change 
-                       if me.checked then
-                           remove .hidden from .col-url
-                           set localStorage['col-url'] to 'visible'
-                       else
-                           add .hidden to .col-url
-                           set localStorage['col-url'] to 'hidden'
-               ">
-            <span class="text-gray-700">URL</span>
-        </label>
         <label class="inline-flex items-center space-x-2" for="toggle-methods">
-            <input id="toggle-methods" type="checkbox" checked class="form-checkbox h-6 w-6 text-blue-600" _="
+            <input id="toggle-methods" type="checkbox" checked class="form-checkbox h-6 w-6 text-blue-600"
+                data-column="col-methods" _="
                    on change 
                        if me.checked then
                            remove .hidden from .col-methods
-                           set localStorage['col-methods'] to 'visible'
                        else
                            add .hidden to .col-methods
-                           set localStorage['col-methods'] to 'hidden'
                ">
             <span class="text-gray-700">Methods</span>
         </label>
+        <label class="inline-flex items-center space-x-2" for="toggle-url">
+            <input id="toggle-url" type="checkbox" checked class="form-checkbox h-6 w-6 text-blue-600"
+                data-column="col-url" _="
+                   on change 
+                       if me.checked then
+                           remove .hidden from .col-url
+                       else
+                           add .hidden to .col-url
+               ">
+            <span class="text-gray-700">URL</span>
+        </label>
         <label class="inline-flex items-center space-x-2" for="toggle-view_func">
-            <input id="toggle-view_func" type="checkbox" checked class="form-checkbox h-6 w-6 text-blue-600" _="
+            <input id="toggle-view_func" type="checkbox" checked class="form-checkbox h-6 w-6 text-blue-600"
+                data-column="col-view_func" _="
                    on change 
                        if me.checked then
                            remove .hidden from .col-view_func
-                           set localStorage['col-view_func'] to 'visible'
                        else
                            add .hidden to .col-view_func
-                           set localStorage['col-view_func'] to 'hidden'
                ">
             <span class="text-gray-700">View Function</span>
         </label>
         <label class="inline-flex items-center space-x-2" for="toggle-description">
-            <input id="toggle-description" type="checkbox" checked class="form-checkbox h-6 w-6 text-blue-600" _="
+            <input id="toggle-description" type="checkbox" checked class="form-checkbox h-6 w-6 text-blue-600"
+                data-column="col-description" _="
                    on change 
                        if me.checked then
                            remove .hidden from .col-description
-                           set localStorage['col-description'] to 'visible'
                        else
                            add .hidden to .col-description
-                           set localStorage['col-description'] to 'hidden'
                ">
             <span class="text-gray-700">Description</span>
         </label>
@@ -99,8 +77,8 @@
             {% for route in routes %}
             <tr class="hover:bg-gray-100 even:bg-gray-50">
                 <td class="py-2 px-4 border-b text-sm text-gray-800 col-endpoint">{{ route.endpoint }}</td>
-                <td class="py-2 px-4 border-b text-sm text-gray-800 col-url">{{ route.url }}</td>
                 <td class="py-2 px-4 border-b text-sm text-gray-800 col-methods">{{ route.methods }}</td>
+                <td class="py-2 px-4 border-b text-sm text-gray-800 col-url">{{ route.url }}</td>
                 <td class="py-2 px-4 border-b text-sm text-gray-800 col-view_func">{{ route.view_func }}</td>
                 <td class="py-2 px-4 border-b text-sm text-gray-800 col-description">
                     {% if route.doc %}